Mapbender Provenance Review

''This is the Mapbender Project copy of Code Provenance Review. See also the status of the Mapbender Incubation Progress.

= External Library Review =

Other licensing model
The following pieces of code need some attention. These modules could be included as external components with a separate download path. Maybe the distribution work group has some ideas how they can manage this.

mod_treefolder
Implements a collapsible folder tree structure which controls the layers of WMS services.

/mapbender/http/html/mod_treefolder.php

License text in mod_treefolder
The following text is included with the code. Please advise on how to proceed.

* Copyright (c) 1999 Polzin GmbH, Duesseldorf. All Rights Reserved. * Author: Lutz Eymers  * Download: http://www.polzin.com/inet/fset_inet.phtml?w=goodies *   * Permission to use, copy, modify, and distribute this software * and its documentation for any purposes and without fee * is hereby granted provided that this copyright notice * appears in all copies. *   * Of course, this software is provided "as is" without express or implied * warranty of any kind. *

class.ezpdf.php
/mapbender/http/classes/class.ezpdf.php

License text in class.ezpdf.php:
The following text is included with the code. Please advise on how to proceed.

// this class will take the basic interaction facilities of the Cpdf class // and make more useful functions so that the user does not have to // know all the ins and outs of pdf presentation to produce something pretty. // // IMPORTANT NOTE // there is no warranty, implied or otherwise with this software. // // version 009 (versioning is linked to class.pdf.php) // // released under a public domain licence. // // Wayne Munro, R&OS Ltd, http://www.ros.co.nz/pdf

class.pdf.php
/mapbender/http/classes/class.pdf.php

License text in class.pdf.php
The following text is included with the code. Please advise on how to proceed.

* Cpdf * * http://www.ros.co.nz/pdf * * A PHP class to provide the basic functionality to create a pdf document without * any requirement for additional modules. * * Note that they companion class CezPdf can be used to extend this class and dramatically * simplify the creation of documents. * * IMPORTANT NOTE * there is no warranty, implied or otherwise with this software. * * LICENCE * This code has been placed in the Public Domain for all to enjoy.

External Library with compatible License
These externl libaries are compatible to the GNU GPL.

phpmailer-1.72
/mapbender/http/classes/phpmailer-1.72

wz-jsgraphics
/mapbender/http/extensions/wz-jsgraphics.js

Provenance: http://www.walterzorn.com

LGPL
= Code Copyright Review =

The objective here is to visit every source file, and identify possible issues, and work to "regularize" things.

class_administration.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

class_connector.php

 * GPL, clean
 * contributed by uli_rothstein
 * copyright by CCGIS

class_database.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_database_table.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_database_table_column.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_database_table_constraint.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_database_table_key.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_exception.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_geomColl.php

 * GPL, clean
 * contributed by uli_rothstein
 * copyright by CCGIS

class_geomObj.php

 * GPL, clean
 * contributed by uli_rothstein
 * copyright by CCGIS

class_gml.php

 * GPL, clean
 * contributed by uli_rothstein
 * copyright by CCGIS

class_gml2.php

 * GPL, clean
 * contributed by uli_rothstein
 * copyright by CCGIS

class_gmlMember.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_gui.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_log.php

 * GPL, please format & check text
 * contributed by astrid_emde
 * copyright by CCGIS

class_mb_exception.php

 * GPL, clean
 * contributed by c_baudson
 * copyright by CCGIS

class_SaveLegend.php

 * GPL, clean
 * contributed by till_adams
 * copyright by CCGIS

class_stripRequest.php

 * GPL, clean
 * contributed by c_baudson, uli_rothstein
 * copyright by CCGIS

class_weldLegend2PNG.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

class_weldMaps2PNG.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

class_weldOverview2PNG.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

class_wfs.php

 * GPL, license text missing
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS missing

class_wfs_conf.php

 * GPL, license text missing
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS missing

class_wmc.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

class_wms.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

/http/extensions/
The directory /http/extensions/ needs some attention. Some of these modules are hacks and just beta they still need a license text. Some of them are so tiny that the license text would be more lines of code than the module itself. Does it even then need to be added?

ext_featureInfoTunnel.php

 * No license reference!
 * contributed by uli_rothstein
 * copyright text missing

ext_weldMaps.php

 * No license reference!
 * contributed by uli_rothstein
 * copyright text missing

geom2wfst.php

 * No license reference!
 * contributed by uli_rothstein
 * copyright text missing

markResult.php

 * No license reference!
 * contributed by uli_rothstein
 * copyright text missing

security_proxy.php

 * No license reference!
 * contributed by uli_rothstein
 * copyright text missing

frameset.html

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

index.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

login.php

 * GPL, clean
 * contributed by astrid_emde, c_baudson, uli_rothstein
 * copyright by CCGIS

dyn_css.php

 * license missing
 * contributed by astrid_emde
 * copyright missing

dyn_js.php

 * license missing
 * contributed by astrid_emde
 * copyright missing

dyn_php.php

 * license missing
 * contributed by astrid_emde
 * copyright missing

/http/javascripts/
Quite a few of these scripts do not conatain a reference to the GPL or a copyright string. In some cases the reference to the license would be longer than the code block itself. This makes sense because it reduces the amount of traffic required to load the client. Is this a problem?

map.php

 * GPL, clean
 * contributed by c_baudson, uli_rothstein
 * copyright CCGIS

needs formatting and cleaning out
This title can be removed once the issue is resolved. Then it will not appear in the toc. Helps orientation.

map_obj.js

 * GPL, clean
 * contributed by c_baudson, uli_rothstein
 * copyright CCGIS

mod_addWMS.php

 * GPL, clean
 * contributed by astrid_emde, bjoern_heuser, thekla_wirkus
 * copyright CCGIS

mod_addWMSfromList.php

 * GPL, clean
 * contributed by astrid_emde, thekla_wirkus
 * copyright CCGIS

mod_addWMSfromfilteredList.php

 * GPL, clean
 * contributed by astrid_emde, thekla_wirkus
 * copyright CCGIS

mod_addWMSgeneralFunctions.js

 * license missing
 * contributed by astrid_emde
 * copyright CCGIS

mod_adminNavigation.js

 * license missing
 * contributed by bjoern_heuser
 * copyright missing

mod_back.php

 * GPL; clean
 * contributed by bjoern_heuser, uli_rothstein
 * copyright CCGIS

mod_box.js

 * license missing
 * contributed by bjoern_heuser, uli_rothstein
 * copyright missing

remove?
see also mod_box1.js (below)

mod_box1.js

 * GPL, very short notation
 * contributed by bjoern_heuser, uli_rothstein
 * copyright missing

remove?
see also mod_box.js (above)

the license reference is very short. Drop altogether or add full style

Licensing: See the GNU General Public License for more details. http://www.gnu.org/copyleft/gpl.html or: mapbender/licence/

mod_cardindex.js

 * license missing
 * contributed by uli_rothstein
 * copyright missing

mod_center1.php

 * GPL; clean
 * contributed by bjoern_heuser, uli_rothstein
 * copyright CCGIS

mod_closePolygon.js

 * license missing
 * contributed by bjoern_heuser, uli_rothstein
 * copyright missing

mod_closePolygonExt.js

 * license missing
 * contributed by bjoern_heuser, uli_rothstein
 * copyright missing

mod_coords.php

 * GPL; clean
 * contributed by astrid_emde, bjoern_heuser, christoph_baudson, uli_rothstein
 * copyright CCGIS

mod_coords_div.php

 * GPL; clean
 * contributed by astrid_emde, bjoern_heuser, christoph_baudson, uli_rothstein
 * copyright CCGIS

check whether required
Check whether both mod_coords.php and mod_coords_div.php are required & check diff.

mod_copyright.php

 * GPL; clean
 * contributed by astrid_emde
 * copyright CCGIS

mod_dependentDiv.php

 * GPL; clean
 * contributed by astrid_emde, bjoern_heuser, christoph_baudson
 * copyright CCGIS

mod_dependentIframe.php

 * GPL; clean
 * contributed by till_adams
 * copyright CCGIS

mod_digitize_js.php

 * license missing
 * contributed by
 * copyright missing

mod_digitize_tab.php

 * GPL; clean
 * contributed by christoph_baudson
 * copyright CCGIS

mod_digitize_tab_gml2java_beta.php

 * GPL; clean
 * contributed by christoph_baudson
 * copyright CCGIS

mod_displayObj.js

 * license missing
 * contributed by
 * copyright missing

mod_displayWmc.php

 * license missing
 * contributed by
 * copyright missing

mod_dragMapSize.php

 * license missing
 * contributed by
 * copyright missing

mod_embedded_legend.php

 * license missing
 * contributed by
 * copyright missing

mod_export_image.php

 * license missing
 * contributed by
 * copyright missing

mod_featureInfo.php

 * license missing
 * contributed by
 * copyright missing

mod_featureInfoRedirect.php

 * license missing
 * contributed by
 * copyright missing

mod_featureInfoTunnel.php

 * license missing
 * contributed by
 * copyright missing

mod_forward.php

 * license missing
 * contributed by
 * copyright missing

mod_getArea.php

 * license missing
 * contributed by
 * copyright missing

mod_insertWmcIntoDb.php

 * license missing
 * contributed by
 * copyright missing

mod_key.php

 * license missing
 * contributed by
 * copyright missing

mod_legend.php

 * license missing
 * contributed by
 * copyright missing

mod_legend_tab.php

 * license missing
 * contributed by
 * copyright missing

mod_loadwmc.php

 * license missing
 * contributed by
 * copyright missing

mod_log.js

 * license missing
 * contributed by
 * copyright missing

mod_measure.php

 * license missing
 * contributed by
 * copyright missing

mod_navFrame.php

 * license missing
 * contributed by
 * copyright missing

mod_pan.php

 * license missing
 * contributed by
 * copyright missing

mod_permanentHighlight.js

 * license missing
 * contributed by
 * copyright missing

mod_print1.php

 * license missing
 * contributed by
 * copyright missing

mod_repaint.php

 * license missing
 * contributed by
 * copyright missing

mod_rubber.js

 * license missing
 * contributed by
 * copyright missing

mod_rubberExt.js

 * license missing
 * contributed by
 * copyright missing

mod_sandclock.php

 * license missing
 * contributed by
 * copyright missing

mod_sandclock2.php

 * license missing
 * contributed by
 * copyright missing

mod_saveWKT.js

 * license missing
 * contributed by
 * copyright missing

mod_savewmc.php

 * license missing
 * contributed by
 * copyright missing

mod_scaleHint.php

 * license missing
 * contributed by
 * copyright missing

mod_scaleSel.php

 * license missing
 * contributed by
 * copyright missing

mod_scaleText.php

 * license missing
 * contributed by
 * copyright missing

mod_scalebar.php

 * license missing
 * contributed by
 * copyright missing

mod_selArea.php

 * license missing
 * contributed by
 * copyright missing

mod_selArea1.php

 * license missing
 * contributed by
 * copyright missing

mod_selectMapsize.php

 * license missing
 * contributed by
 * copyright missing

mod_setBBOX1.php

 * license missing
 * contributed by
 * copyright missing

mod_setBackground.php

 * license missing
 * contributed by
 * copyright missing

mod_setBackground_all.php

 * license missing
 * contributed by
 * copyright missing

mod_setTimeout.php

 * license missing
 * contributed by
 * copyright missing

mod_state.php

 * license missing
 * contributed by
 * copyright missing

mod_tab.js

 * license missing
 * contributed by
 * copyright missing

mod_tab.php

 * license missing
 * contributed by
 * copyright missing

mod_tab_gui.js

 * license missing
 * contributed by
 * copyright missing

mod_tab_gui_cb.js

 * license missing
 * contributed by
 * copyright missing

mod_tab_gui_de.js

 * license missing
 * contributed by
 * copyright missing

mod_toggleModule.php

 * license missing
 * contributed by
 * copyright missing

mod_treeConf.js

 * license missing
 * contributed by
 * copyright missing

mod_usemap.php

 * license missing
 * contributed by
 * copyright missing

mod_wfs_SpatialRequest.php

 * license missing
 * contributed by
 * copyright missing

mod_zoomCoords.php

 * license missing
 * contributed by
 * copyright missing

mod_zoomFull.php

 * license missing
 * contributed by
 * copyright missing

mod_zoomIn1.php

 * license missing
 * contributed by
 * copyright missing

mod_zoomOut1.php

 * license missing
 * contributed by
 * copyright missing

wfs.js

 * license missing
 * contributed by
 * copyright missing

wfs_obj.js

 * license missing
 * contributed by
 * copyright missing