GeoMajas Provenance Review - Revision history

Wiki-Joachimvda at 10:48, 17 June 2010

2010-06-17T10:48:48Z

Wiki-Joachimvda at 19:11, 2 June 2010

2010-06-02T19:11:17Z

Wiki-Joachimvda at 09:54, 19 May 2010

2010-05-19T09:54:38Z

Wiki-Joachimvda at 09:54, 19 May 2010

2010-05-19T09:54:04Z

Wiki-Joachimvda at 09:38, 19 May 2010

2010-05-19T09:38:25Z

Wiki-Joachimvda at 15:18, 27 April 2010

2010-04-27T15:18:17Z

Wiki-Joachimvda at 11:05, 23 April 2010

2010-04-23T11:05:37Z

Wiki-Joachimvda at 11:00, 23 April 2010

2010-04-23T11:00:02Z

Wiki-Pagameba: New page: This is a place holder for the GeoMajas Code Provenance Review

2010-02-25T13:29:39Z

New page: This is a place holder for the GeoMajas Code Provenance Review

New page

This is a place holder for the GeoMajas Code Provenance Review

@@ Line 37: / Line 37: @@
 Action points resulting from the review:
-* All resource directories needs a "LICENSE.txt" file indicating where the files came from when not original work of the project (original work includes stuff like screen shots or specially created graphics). All resources for which the source and/or license is unclear need to be removed or replaced by data for which the license is acceptable (incomplete).
+* All resource directories needs a "LICENSE.txt" file indicating where the files came from when not original work of the project (original work includes stuff like screen shots or specially created graphics). All resources for which the source and/or license is unclear need to be removed or replaced by data for which the license is acceptable (DONE).
 * The back-end and all plug-ins need to maintain a list with copyright/license details (DONE).
 * These details need to be logged when starting the application (DONE).
 * A command needs to be created to get this information from the system (DONE).
-* Faces need to display this copyright/license information in an about box or similar. This needs to be a requirement for graduating a face (incomplete).
+* Faces need to display this copyright/license information in an about box or similar. This needs to be a requirement for graduating a face (DONE).
-* Contributors guide needs to be adjusted to mention that copyright/license info needs to be maintained on the back-end and plug-ins (incomplete).
+* Contributors guide needs to be adjusted to mention that copyright/license info needs to be maintained on the back-end and plug-ins (DONE).

@@ Line 37: / Line 37: @@
 Action points resulting from the review:
-* All resource directories needs a "LICENSE.txt" file indicating where the files came from when not original work of the project (original work includes stuff like screen shots or specially created graphics) (incomplete).
+* All resource directories needs a "LICENSE.txt" file indicating where the files came from when not original work of the project (original work includes stuff like screen shots or specially created graphics). All resources for which the source and/or license is unclear need to be removed or replaced by data for which the license is acceptable (incomplete).
 * The back-end and all plug-ins need to maintain a list with copyright/license details (DONE).
 * These details need to be logged when starting the application (DONE).

← Older revision		Revision as of 09:54, 19 May 2010
Line 7:		Line 7:

	== External components "in source tree" for the project ==		== External components "in source tree" for the project ==
		+
		+	none
		+
	== External dependencies ==		== External dependencies ==

@@ Line 26: / Line 26: @@
 See [http://spreadsheets.google.com/pub?key=t7zH_2KykoFjllbW0QBQaXw&output=html spreadsheet].
-= Review Document =
+= Review Result =
 The result of the provenance review is two fold.  First, there is clarification and "fixes" done during the review.  For instance, adding missing copyright notices, or factoring out external libraries.  The second is a review report with a fairly detailed list of outstanding issues, ambiguities and information of note.
@@ Line 32: / Line 32: @@
 See [http://spreadsheets.google.com/pub?key=t7zH_2KykoFjllbW0QBQaXw&output=html spreadsheet].
-The review document will be distributed to the project PSC members, as well as the incubation committee.  Based on it, the incubation committee may require the project to do additional work, either resolving ambiguities, factoring items out, or rewriting questional components.
+Action points resulting from the review:
-When completed, a much briefer form of the review document should be prepared, just listing information that would be pertinent to folks using the project.  Essentially a summary.  This summary might live in source control as README.LICENSE or something similar.
+* All resource directories needs a "LICENSE.txt" file indicating where the files came from when not original work of the project (original work includes stuff like screen shots or specially created graphics) (incomplete).

@@ Line 14: / Line 14: @@
 = Code Copyright Review =
 History :
-* The original code was developed by DFC nv
+* The original code was developed by DFC nv.
-* The IP was bought by Geosparc nv from DFC nv on 01 Jan 2009
+* The IP was bought by Geosparc nv from DFC nv on 01 Jan 2009.
-* Any changes since code is owned by Geosparc nv should by covered by a CLA (Contributer's License Agreement), transferring copyright to Geosparc nv
+* Any changes since code is owned by Geosparc nv are either by covered by a CLA (Contributer's License Agreement) or an employment contract, transferring copyright to Geosparc nv.
 General, see [http://files.geomajas.org/maven/trunk/geomajas/contributorguide/html/index.html contributors guide] :
 * All Java files contain a copyright statement which is checked as part of the build.
-* All authors should add there name in the list of authors at the top of the files.
+* All authors are required to add their name in the list of authors at the top of the files.
 The objective here is to visit every source file, and identify possible issues, and work to "regularize" things.

← Older revision		Revision as of 11:05, 23 April 2010
Line 1:		Line 1:
	{{Template:Code_Provenance_Review_Goals}}		{{Template:Code_Provenance_Review_Goals}}
		+
		+	[http://www.osgeo.org/incubator/process/codereview.html Guidelines]

	= Library/Component Review =		= Library/Component Review =

← Older revision		Revision as of 11:00, 23 April 2010
Line 1:		Line 1:
−	This is a ~~place holder~~ for the ~~GeoMajas Code Provenance Review~~	+	{{Template:Code_Provenance_Review_Goals}}
		+
		+	= Library/Component Review =
		+
		+
		+	== External components "in source tree" for the project ==
		+	== External dependencies ==
		+
		+	See [http://spreadsheets.google.com/pub?key=t7zH_2KykoFjllbW0QBQaXw&output=html spreadsheet].
		+
		+
		+	= Code Copyright Review =
		+	History :
		+	* The original code was developed by DFC nv
		+	* The IP was bought by Geosparc nv from DFC nv on ... (Jan 2009?)
		+	* Any changes since code is owned by Geosparc nv should by covered by a CLA (Contributer's License Agreement), transferring copyright to Geosparc nv
		+
		+	General, see [http://files.geomajas.org/maven/trunk/geomajas/contributorguide/html/index.html contributors guide] :
		+	* All Java files contain a copyright statement which is checked as part of the build.
		+	* All authors should add there name in the list of authors at the top of the files.
		+
		+	The objective here is to visit every source file, and identify possible issues, and work to "regularize" things.
		+
		+	See [http://spreadsheets.google.com/pub?key=t7zH_2KykoFjllbW0QBQaXw&output=html spreadsheet].
		+
		+	= Review Document =
		+
		+	The result of the provenance review is two fold. First, there is clarification and "fixes" done during the review. For instance, adding missing copyright notices, or factoring out external libraries. The second is a review report with a fairly detailed list of outstanding issues, ambiguities and information of note.
		+
		+	See [http://spreadsheets.google.com/pub?key=t7zH_2KykoFjllbW0QBQaXw&output=html spreadsheet].
		+
		+	The review document will be distributed to the project PSC members, as well as the incubation committee. Based on it, the incubation committee may require the project to do additional work, either resolving ambiguities, factoring items out, or rewriting questional components.
		+
		+	When completed, a much briefer form of the review document should be prepared, just listing information that would be pertinent to folks using the project. Essentially a summary. This summary might live in source control as README.LICENSE or something similar.
		+
		+
		+	== Copyright Header ==
		+	It is sufficient to refer to a single copy of the license agreement for the project, but each file should include an indication of what the license is, and the location of the full license document.
		+
		+	The header which needs to be included in all Java files (JavaScript and XML files have the same text but using different formatting/comment style):
		+
		+	<pre>
		+	/*
		+	* This file is part of Geomajas, a component framework for building
		+	* rich Internet applications (RIA) with sophisticated capabilities for the
		+	* display, analysis and management of geographic information.
		+	* It is a building block that allows developers to add maps
		+	* and other geographic data capabilities to their web applications.
		+	*
		+	* Copyright 2008-2010 Geosparc, http://www.geosparc.com, Belgium
		+	*
		+	* This program is free software: you can redistribute it and/or modify
		+	* it under the terms of the GNU Affero General Public License as
		+	* published by the Free Software Foundation, either version 3 of the
		+	* License, or (at your option) any later version.
		+	*
		+	* This program is distributed in the hope that it will be useful,
		+	* but WITHOUT ANY WARRANTY; without even the implied warranty of
		+	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
		+	* GNU Affero General Public License for more details.
		+	*
		+	* You should have received a copy of the GNU Affero General Public License
		+	* along with this program. If not, see <http://www.gnu.org/licenses/>.
		+	*/
		+	</pre>
		+
		+	[[Category:Incubation]]